-
Notifications
You must be signed in to change notification settings - Fork 13.8k
Add new --bypass-ignore-backends
option
#147633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add new --bypass-ignore-backends
option
#147633
Conversation
Some changes occurred in src/tools/compiletest cc @jieyouxu This PR modifies If appropriate, please update |
To provide more context here, I suggested this to allow gradual removal of That being said, now that I think about it, I wonder how would the workflow look like. If you use the option that this PR adds, it would just run all tests; some of them would fail, some of them would succeed. But it wouldn't be trivial to figure out which one of those that succeeded actually contain I guess what I really wanted was something like @jieyouxu Let me know if you have any opinions on this. |
Here are the 3 use cases we currently have in the CI of cg_gcc I can think of:
We already have the logic to do this in the CI of cg_gcc, but we need a flag like |
Maybe we could do a general override mechanism, something like |
I guess that makes sense if there are other |
Fixes #147063.
It adds a new option to
bootstrap
to allow to ignore//@ ignore-backends
statements in tests.cc @jieyouxu @antoyo
r? @Kobzol